Add dtrace worker tag support#754
Conversation
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
This is how I'd do it. Maybe the branch logic could be elsewhere, but "dtrace is installed" is a feature of the worker, and I think tags are great for such features.
|
I generally want to move to using tags for configure options -- but mostly builder tags: e.g. having separate factories for Does that look like a good direction? |
For me it does sound that it;s a proper direction as it would reduce a lot of subclassing, given of course that an option to do extra customizations without much hassle will be there. |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
So dtrace is not enabled on RHEL8 workers. DTrace doesn't work on RHEL8?
It should but the upstream fix is on 3.15+, RHEL8 workers test up to 3.12. |
|
Converted to a draft, there is an issue with the probes on shared builds when running the tests. Granted the test needs sudo or systemtap permission but I'd rather have this fixed first than risk buildbots failing unexpectedly. |
3 participants
No description provided.